beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 17:40:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

HackStudio: Add context option to set execution point while debugging

Browse source 
You can now right click in HackStudio's editor while debugging and
have the option to instantly move the current execution position to
the current line.
This commit is contained in:
FalseHonesty 2021-04-27 21:20:20 -04:00 committed by Linus Groh
parent 31c3382577
commit b0145ea529
Notes: sideshowbarker 2024-07-18 19:00:35 +09:00 
Author: https://github.com/FalseHonesty
Commit: https://github.com/SerenityOS/serenity/commit/b0145ea5290
Pull-request: https://github.com/SerenityOS/serenity/pull/6701
4 changed files with 30 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Userland/DevTools/HackStudio/Debugger/Debugger.cpp
View file

@ -77,6 +77,21 @@ void Debugger::on_breakpoint_change(const String& file, size_t line, BreakpointC
}
}
bool Debugger::set_execution_position(const String& file, size_t line)
{
auto position = create_source_position(file, line);
auto session = Debugger::the().session();
if (!session)
return false;
auto address = session->get_address_from_source_position(position.file_path, position.line_number);
if (!address.has_value())
return false;
auto registers = session->get_registers();
registers.eip = address.value().address;
session->set_registers(registers);
return true;
}
Debug::DebugInfo::SourcePosition Debugger::create_source_position(const String& file, size_t line)
{
if (file.starts_with("/"))

1
Userland/DevTools/HackStudio/Debugger/Debugger.h
View file

@ -34,6 +34,7 @@ public:
static bool is_initialized();
void on_breakpoint_change(const String& file, size_t line, BreakpointChange change_type);
bool set_execution_position(const String& file, size_t line);
void set_executable_path(const String& path) { m_executable_path = path; }
void set_source_root(const String& source_root) { m_source_root = source_root; }

13
Userland/DevTools/HackStudio/Editor.cpp
View file

@ -52,7 +52,20 @@ Editor::Editor()
auto dialog = EvaluateExpressionDialog::construct(window());
dialog->exec();
});
m_move_execution_to_line_action = GUI::Action::create("Set execution point to line", [this](auto&) {
if (!execution_position().has_value()) {
GUI::MessageBox::show(window(), "Program must be paused", "Error", GUI::MessageBox::Type::Error);
return;
}
auto success = Debugger::the().set_execution_position(currently_open_file(), cursor().line());
if (success) {
set_execution_position(cursor().line());
} else {
GUI::MessageBox::show(window(), "Failed to set execution position", "Error", GUI::MessageBox::Type::Error);
}
});
add_custom_context_menu_action(*m_evaluate_expression_action);
add_custom_context_menu_action(*m_move_execution_to_line_action);
}
Editor::~Editor()

1
Userland/DevTools/HackStudio/Editor.h
View file

@ -104,6 +104,7 @@ private:
bool m_hovering_clickable { false };
bool m_autocomplete_in_focus { false };
RefPtr<GUI::Action> m_evaluate_expression_action;
RefPtr<GUI::Action> m_move_execution_to_line_action;
OwnPtr<LanguageClient> m_language_client;
};