beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 17:40:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Add parsing for NumericStyleValue

Browse source 
This StyleValue can hold an arbitrary float value.
This commit is contained in:
Tobias Christiansen 2021-06-03 21:59:41 +02:00 committed by Ali Mohammad Pur
parent ae3e6510d6
commit af4d80af4d
Notes: sideshowbarker 2024-07-18 16:34:54 +09:00 
Author: https://github.com/TobyAsE
Commit: https://github.com/SerenityOS/serenity/commit/af4d80af4d8
Pull-request: https://github.com/SerenityOS/serenity/pull/7669
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/awesomekling
2 changed files with 27 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/CSS/Parser/DeprecatedCSSParser.cpp
View file

@ -240,8 +240,12 @@ RefPtr<CSS::StyleValue> parse_css_value(const CSS::ParsingContext& context, cons
}
auto length = parse_length(context, string, is_bad_length);
if (is_bad_length)
if (is_bad_length) {
auto float_number = try_parse_float(string);
if (float_number.has_value())
return CSS::NumericStyleValue::create(float_number.value());
return nullptr;
}
if (!length.is_undefined())
return CSS::LengthStyleValue::create(length);

22
Userland/Libraries/LibWeb/CSS/StyleValue.h
View file

@ -207,6 +207,7 @@ public:
Image,
Position,
CustomProperty,
Numeric,
};
Type type() const { return m_type; }
@ -220,6 +221,7 @@ public:
bool is_length() const { return type() == Type::Length; }
bool is_position() const { return type() == Type::Position; }
bool is_custom_property() const { return type() == Type::CustomProperty; }
bool is_numeric() const { return type() == Type::Numeric; }
virtual String to_string() const = 0;
virtual Length to_length() const { return Length::make_auto(); }
@ -266,6 +268,26 @@ private:
String m_custom_property_name {};
};
class NumericStyleValue : public StyleValue {
public:
static NonnullRefPtr<NumericStyleValue> create(float value)
{
return adopt_ref(*new NumericStyleValue(value));
}
float value() const { return m_value; }
String to_string() const override { return String::formatted("{}", m_value); }
private:
explicit NumericStyleValue(float value)
: StyleValue(Type::Numeric)
, m_value(value)
{
}
float m_value { 0 };
};
class StringStyleValue : public StyleValue {
public:
static NonnullRefPtr<StringStyleValue> create(const String& string)