beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibGfx/ILBM: Ensure decompressed body chunk data is the correct length

Browse source
This commit is contained in:
Tim Ledbetter 2023-10-30 16:18:12 +00:00 committed by Andreas Kling
parent 39f7f1e84c
commit ae6c39e501
Notes: sideshowbarker 2024-07-16 20:21:48 +09:00 
Author: https://github.com/tcl3
Commit: https://github.com/SerenityOS/serenity/commit/ae6c39e501
Pull-request: https://github.com/SerenityOS/serenity/pull/21699
Reviewed-by: https://github.com/warpdesign
3 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibGfx/TestImageDecoder.cpp
View file

@ -154,6 +154,7 @@ TEST_CASE(test_ilbm_malformed_header)
TEST_CASE(test_ilbm_malformed_frame)
{
Array test_inputs = {
TEST_INPUT("ilbm/incorrect-uncompressed-size.iff"sv),
TEST_INPUT("ilbm/missing-body-chunk.iff"sv)
};

BIN
Tests/LibGfx/test-inputs/ilbm/incorrect-uncompressed-size.iff Normal file
View file

Binary file not shown.

12
Userland/Libraries/LibGfx/ImageFormats/ILBMLoader.cpp
View file

@ -176,7 +176,14 @@ static ErrorOr<ByteBuffer> uncompress_byte_run(ReadonlyBytes data, ILBMLoadingCo
auto length = data.size();
dbgln_if(ILBM_DEBUG, "uncompress_byte_run pitch={} size={}", context.pitch, data.size());
auto plane_data = TRY(ByteBuffer::create_uninitialized(context.pitch * context.bm_header.height * context.bm_header.planes));
size_t plane_data_size = context.pitch * context.bm_header.height * context.bm_header.planes;
// The maximum run length of this compression method is 127 bytes, so the uncompressed size
// cannot be more than 127 times the size of the chunk we are decompressing.
if (plane_data_size > NumericLimits<u32>::max() || ceil_div(plane_data_size, 127ul) > length)
return Error::from_string_literal("Uncompressed data size too large");
auto plane_data = TRY(ByteBuffer::create_uninitialized(plane_data_size));
u32 index = 0;
u32 read_bytes = 0;
@ -197,6 +204,9 @@ static ErrorOr<ByteBuffer> uncompress_byte_run(ReadonlyBytes data, ILBMLoadingCo
}
}
if (index != plane_data_size)
return Error::from_string_literal("Unexpected end of chunk while decompressing data");
return plane_data;
}