beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Replace all explicit specialisations of Traits with a single one

Browse source 
This commit un-confuses the many specialisations of AK::Traits, and
makes it work correctly for all integral types.
Prior to this, `AK::Traits<size_t>` would've been instantiating the
base Traits implementation, not `Traits<u32>` or `Traits<u64>`.
This commit is contained in:
Ali Mohammad Pur 2021-07-12 22:38:03 +04:30 committed by Ali Mohammad Pur
parent 84b028bd71
commit ad328f852b
Notes: sideshowbarker 2024-07-18 09:09:50 +09:00 
Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/ad328f852b8
Pull-request: https://github.com/SerenityOS/serenity/pull/8695
1 changed files with 9 additions and 45 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

54
AK/Traits.h
View file

@ -23,52 +23,16 @@ template<typename T>
struct Traits : public GenericTraits<T> {
};
template<>
struct Traits<int> : public GenericTraits<int> {
template<typename T>
requires(IsIntegral<T>) struct Traits<T> : public GenericTraits<T> {
static constexpr bool is_trivial() { return true; }
static unsigned hash(int i) { return int_hash(i); }
};
template<>
struct Traits<char> : public GenericTraits<char> {
static constexpr bool is_trivial() { return true; }
static unsigned hash(char c) { return int_hash(c); }
};
template<>
struct Traits<i16> : public GenericTraits<i16> {
static constexpr bool is_trivial() { return true; }
static unsigned hash(i16 i) { return int_hash(i); }
};
template<>
struct Traits<i64> : public GenericTraits<i64> {
static constexpr bool is_trivial() { return true; }
static unsigned hash(i64 i) { return u64_hash(i); }
};
template<>
struct Traits<unsigned> : public GenericTraits<unsigned> {
static constexpr bool is_trivial() { return true; }
static unsigned hash(unsigned u) { return int_hash(u); }
};
template<>
struct Traits<u8> : public GenericTraits<u8> {
static constexpr bool is_trivial() { return true; }
static unsigned hash(u8 u) { return int_hash(u); }
};
template<>
struct Traits<u16> : public GenericTraits<u16> {
static constexpr bool is_trivial() { return true; }
static unsigned hash(u16 u) { return int_hash(u); }
};
template<>
struct Traits<u64> : public GenericTraits<u64> {
static constexpr bool is_trivial() { return true; }
static unsigned hash(u64 u) { return u64_hash(u); }
static constexpr unsigned hash(T value)
{
if constexpr (sizeof(T) < 8)
return int_hash(value);
else
return u64_hash(value);
}
};
template<typename T>