beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 01:20:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Mark heap cell values stored in Set instances

Browse source 
This makes sure they dont get garbage collected while stored in a Set.
This commit is contained in:
Idan Horowitz 2021-06-09 18:01:06 +03:00 committed by Linus Groh
parent 6a0d1fa259
commit ad0e3c0e54
Notes: sideshowbarker 2024-07-18 12:33:28 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/ad0e3c0e548
Pull-request: https://github.com/SerenityOS/serenity/pull/7945
Reviewed-by: https://github.com/linusg ✅
2 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibJS/Runtime/Set.cpp
View file

@ -34,4 +34,11 @@ Set* Set::typed_this(VM& vm, GlobalObject& global_object)
return static_cast<Set*>(this_object); return static_cast<Set*>(this_object);
} }
void Set::visit_edges(Cell::Visitor& visitor)
{
Object::visit_edges(visitor);
for (auto& value : m_values)
visitor.visit(value);
}
} }

2
Userland/Libraries/LibJS/Runtime/Set.h
View file

@ -47,6 +47,8 @@ public:
HashTable<Value, ValueTraits>& values() { return m_values; }; HashTable<Value, ValueTraits>& values() { return m_values; };
private: private:
virtual void visit_edges(Visitor& visitor) override;
HashTable<Value, ValueTraits> m_values; // FIXME: Replace with a HashTable that maintains a linked list of insertion order for correct iteration order HashTable<Value, ValueTraits> m_values; // FIXME: Replace with a HashTable that maintains a linked list of insertion order for correct iteration order
}; };