beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Change the signature of AK::encode_base64() to use Span.

Browse source
This commit is contained in:
asynts 2020-07-27 14:16:33 +02:00 committed by Andreas Kling
parent 5fa0fdb219
commit abe925e4b0
Notes: sideshowbarker 2024-07-19 04:32:39 +09:00 
Author: https://github.com/asynts
Commit: https://github.com/SerenityOS/serenity/commit/abe925e4b08
Pull-request: https://github.com/SerenityOS/serenity/pull/2903
5 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
AK/Base64.cpp
View file

@ -86,7 +86,7 @@ ByteBuffer decode_base64(const StringView& input)
return ByteBuffer::copy(output.data(), output.size());
}
String encode_base64(const ByteBuffer& input)
String encode_base64(ReadonlyBytes input)
{
StringBuilder output;

3
AK/Base64.h
View file

@ -27,12 +27,13 @@
#pragma once
#include <AK/Forward.h>
#include <AK/Span.h>
namespace AK {
ByteBuffer decode_base64(const StringView&);
String encode_base64(const ByteBuffer&);
String encode_base64(ReadonlyBytes);
}

2
AK/Tests/TestBase64.cpp
View file

@ -49,7 +49,7 @@ TEST_CASE(test_decode)
TEST_CASE(test_encode)
{
auto encode_equal = [&](const char* input, const char* expected) {
auto encoded = encode_base64(ByteBuffer::wrap(input, strlen(input)));
auto encoded = encode_base64({ input, strlen(input) });
EXPECT(encoded == String(expected));
};

4
Libraries/LibWeb/Bindings/WindowObject.cpp
View file

@ -28,8 +28,8 @@
#include <AK/ByteBuffer.h>
#include <AK/FlyString.h>
#include <AK/Function.h>
#include <AK/Utf8View.h>
#include <AK/String.h>
#include <AK/Utf8View.h>
#include <LibJS/Interpreter.h>
#include <LibJS/Runtime/Error.h>
#include <LibJS/Runtime/Function.h>
@ -278,7 +278,7 @@ JS_DEFINE_NATIVE_FUNCTION(WindowObject::btoa)
byte_string.append(codepoint);
}
auto encoded = encode_base64(ByteBuffer::wrap(byte_string.data(), byte_string.size()));
auto encoded = encode_base64(byte_string.span());
return JS::js_string(interpreter, move(encoded));
}

2
Userland/base64.cpp
View file

@ -75,6 +75,6 @@ int main(int argc, char** argv)
return 0;
}
auto encoded = encode_base64(buffer);
auto encoded = encode_base64(buffer.span());
printf("%s\n", encoded.characters());
}