beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibGUI: Add read-only effective size properties for debugging

Browse source 
These new read-only properties help with debugging layouts, by exposing
the size values that are actually used for final size determination.
This commit is contained in:
FrHun 2022-05-16 18:40:14 +02:00 committed by Sam Atkins
parent 68ad5f3780
commit aba6422e11
Notes: sideshowbarker 2024-07-17 20:33:50 +09:00 
Author: https://github.com/frhun
Commit: https://github.com/SerenityOS/serenity/commit/aba6422e11
Pull-request: https://github.com/SerenityOS/serenity/pull/14261
Reviewed-by: https://github.com/AtkinsSJ ✅
Reviewed-by: https://github.com/MacDue
Reviewed-by: https://github.com/mjz19910
2 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibGUI/UIDimensions.h
View file

@ -285,6 +285,13 @@ inline auto clamp<GUI::UIDimension>(GUI::UIDimension const& input, GUI::UIDimens
return result.has_value(); \
});
#define REGISTER_READONLY_UI_DIMENSION_PROPERTY(property_name, getter) \
register_property( \
property_name, \
[this] { \
return this->getter().as_json_value(); \
});
#define REGISTER_UI_SIZE_PROPERTY(property_name, getter, setter) \
register_property( \
property_name, \
@ -309,3 +316,14 @@ inline auto clamp<GUI::UIDimension>(GUI::UIDimension const& input, GUI::UIDimens
} \
return false; \
});
#define REGISTER_READONLY_UI_SIZE_PROPERTY(property_name, getter) \
register_property( \
property_name, \
[this] { \
auto size = this->getter(); \
JsonObject size_object; \
size_object.set("width", size.width().as_json_value()); \
size_object.set("height", size.height().as_json_value()); \
return size_object; \
});

2
Userland/Libraries/LibGUI/Widget.cpp
View file

@ -50,8 +50,10 @@ Widget::Widget()
REGISTER_STRING_PROPERTY("tooltip", tooltip, set_tooltip);
REGISTER_UI_SIZE_PROPERTY("min_size", min_size, set_min_size);
REGISTER_READONLY_UI_SIZE_PROPERTY("effective_min_size", effective_min_size);
REGISTER_UI_SIZE_PROPERTY("max_size", max_size, set_max_size);
REGISTER_UI_SIZE_PROPERTY("preferred_size", preferred_size, set_preferred_size);
REGISTER_READONLY_UI_SIZE_PROPERTY("effective_preferred_size", effective_preferred_size);
REGISTER_INT_PROPERTY("width", width, set_width);
REGISTER_UI_DIMENSION_PROPERTY("min_width", min_width, set_min_width);
REGISTER_UI_DIMENSION_PROPERTY("max_width", max_width, set_max_width);