beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Kernel/aarch64: Stub out atomic SafeMem functions

Browse source 
These are used in futexes, which are needed if we want to get further in
`run-tests`.

For now, we have no way to return a non-fatal error if an access fault
is raised while executing these, so the kernel will panic. Some would
consider this a DoS vulnerability where a malicious userspace app can
crash the kernel by passing bogus pointers to it, but I prefer to call
it progress :^)
This commit is contained in:
Daniel Bertalan 2023-05-19 11:52:52 +02:00 committed by Andreas Kling
parent 09ef2c14e9
commit ab279c850b
Notes: sideshowbarker 2024-07-17 20:33:50 +09:00 
Author: https://github.com/BertalanD
Commit: https://github.com/SerenityOS/serenity/commit/ab279c850b
Pull-request: https://github.com/SerenityOS/serenity/pull/18917
Reviewed-by: https://github.com/kleinesfilmroellchen ✅
1 changed files with 16 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
Kernel/Arch/aarch64/SafeMem.cpp
View file

@ -29,34 +29,35 @@ bool safe_memcpy(void* dest_ptr, void const* src_ptr, unsigned long n, void*&)
return true;
}
Optional<bool> safe_atomic_compare_exchange_relaxed(u32 volatile*, u32&, u32)
Optional<bool> safe_atomic_compare_exchange_relaxed(u32 volatile* var, u32& expected, u32 val)
{
TODO_AARCH64();
return {};
// FIXME: Handle access faults.
return AK::atomic_compare_exchange_strong(var, expected, val, AK::memory_order_relaxed);
}
Optional<u32> safe_atomic_load_relaxed(u32 volatile*)
Optional<u32> safe_atomic_load_relaxed(u32 volatile* var)
{
TODO_AARCH64();
return {};
// FIXME: Handle access faults.
return AK::atomic_load(var, AK::memory_order_relaxed);
}
Optional<u32> safe_atomic_fetch_add_relaxed(u32 volatile*, u32)
Optional<u32> safe_atomic_fetch_add_relaxed(u32 volatile* var, u32 val)
{
TODO_AARCH64();
return {};
// FIXME: Handle access faults.
return AK::atomic_fetch_add(var, val, AK::memory_order_relaxed);
}
Optional<u32> safe_atomic_exchange_relaxed(u32 volatile*, u32)
Optional<u32> safe_atomic_exchange_relaxed(u32 volatile* var, u32 val)
{
TODO_AARCH64();
return {};
// FIXME: Handle access faults.
return AK::atomic_exchange(var, val, AK::memory_order_relaxed);
}
bool safe_atomic_store_relaxed(u32 volatile*, u32)
bool safe_atomic_store_relaxed(u32 volatile* var, u32 val)
{
TODO_AARCH64();
return {};
// FIXME: Handle access faults.
AK::atomic_store(var, val);
return true;
}
bool handle_safe_access_fault(RegisterState&, FlatPtr)