beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Appending 0 bytes to a ByteBuffer should be a no-op (#1699)

Browse source 
- inserting an empty string into LibLine Editor triggered an assertion
  trying to grow a ByteBuffer by 0 bytes.
This commit is contained in:
Paul Redmond 2020-04-08 11:04:37 -04:00 committed by GitHub
parent 38dfd04633
commit a9779e12ea
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
Notes: sideshowbarker 2024-07-19 07:48:45 +09:00 
Author: https://github.com/predmond
Commit: https://github.com/SerenityOS/serenity/commit/a9779e12ea6
Pull-request: https://github.com/SerenityOS/serenity/pull/1699
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
AK/ByteBuffer.h
View file

@ -211,6 +211,9 @@ public:
void append(const void* data, size_t data_size)
{
if (data_size == 0)
return;
ASSERT(data != nullptr);
int old_size = size();
grow(size() + data_size);
__builtin_memcpy(this->data() + old_size, data, data_size);