beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 01:20:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

PixelPaint: Improve brushtool gradient for low hardness

Browse source 
This patch mitigates a rough gradient for the brush tool with a low
hardness. Previously the gradient alpha value was truncated by the type
conversion to int. Now the desired alpha value is scaled up to mitigate
the information loss due to type conversion which results in a much
smoother gradient.
This commit is contained in:
Torstennator 2022-10-09 20:12:23 +02:00 committed by Linus Groh
parent e520b9c3a3
commit a66dbef1ed
Notes: sideshowbarker 2024-07-17 18:49:10 +09:00 
Author: https://github.com/Torstennator
Commit: https://github.com/SerenityOS/serenity/commit/a66dbef1ed
Pull-request: https://github.com/SerenityOS/serenity/pull/15526
Reviewed-by: https://github.com/AtkinsSJ
Reviewed-by: https://github.com/MacDue ✅
Reviewed-by: https://github.com/linusg
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
Userland/Applications/PixelPaint/Tools/BrushTool.cpp
View file

@ -46,10 +46,7 @@ void BrushTool::on_mousedown(Layer* layer, MouseEvent& event)
return;
}
int const first_draw_opacity = 10;
for (int i = 0; i < first_draw_opacity; ++i)
draw_point(layer->get_scratch_edited_bitmap(), color_for(layer_event), layer_event.position());
draw_point(layer->get_scratch_edited_bitmap(), color_for(layer_event), layer_event.position());
layer->did_modify_bitmap(Gfx::IntRect::centered_on(layer_event.position(), Gfx::IntSize { m_size * 2, m_size * 2 }));
m_last_position = layer_event.position();
@ -89,6 +86,7 @@ Color BrushTool::color_for(GUI::MouseEvent const& event)
void BrushTool::draw_point(Gfx::Bitmap& bitmap, Gfx::Color const& color, Gfx::IntPoint const& point)
{
constexpr auto flow_scale = 10;
for (int y = point.y() - size(); y < point.y() + size(); y++) {
for (int x = point.x() - size(); x < point.x() + size(); x++) {
auto distance = point.distance_from({ x, y });
@ -97,9 +95,9 @@ void BrushTool::draw_point(Gfx::Bitmap& bitmap, Gfx::Color const& color, Gfx::In
if (distance >= size())
continue;
auto falloff = get_falloff(distance);
auto falloff = get_falloff(distance) * flow_scale;
auto pixel_color = color;
pixel_color.set_alpha(falloff * 255);
pixel_color.set_alpha(AK::min(falloff * 255, 255));
bitmap.set_pixel(x, y, bitmap.get_pixel(x, y).blend(pixel_color));
}
}