beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 00:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibGfx: Load correct durations for gifs

Browse source 
The wrong shift effectively set the upper byte to 0, meaning that
durations longer than 255 centiseconds (2.55 seconds) were wrapped
around. See serenity-fuzz-corpora for an example.
This commit is contained in:
Ben Wiederhake 2021-05-30 12:37:17 +02:00 committed by Linus Groh
parent 774107f37c
commit a49c77b76d
Notes: sideshowbarker 2024-07-18 17:10:07 +09:00 
Author: https://github.com/BenWiederhake
Commit: https://github.com/SerenityOS/serenity/commit/a49c77b76d0
Pull-request: https://github.com/SerenityOS/serenity/pull/7584
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGfx/GIFLoader.cpp
View file

@ -511,7 +511,7 @@ static bool load_gif_frame_descriptors(GIFLoadingContext& context)
u8 transparent = sub_block[0] & 1;
current_image->transparent = transparent == 1;
u16 duration = sub_block[1] + ((u16)sub_block[2] >> 8);
u16 duration = sub_block[1] + ((u16)sub_block[2] << 8);
current_image->duration = duration;
current_image->transparency_index = sub_block[3];