beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibHTTP+ProtocolServer+LibGemini: Remove Request::schedule()

Browse source 
This API is only used for HttpRequest, but replicated in GeminiRequest
without an actual user, so remove it and construct the job like the rest
of the protocols.
This commit is contained in:
AnotherTest 2020-10-29 11:50:19 +03:30 committed by Andreas Kling
parent b11b4b29e9
commit a461526b07
Notes: sideshowbarker 2024-07-19 01:38:02 +09:00 
Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/a461526b073
Pull-request: https://github.com/SerenityOS/serenity/pull/3867
Reviewed-by: https://github.com/awesomekling
5 changed files with 4 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibGemini/GeminiRequest.cpp
View file

@ -39,13 +39,6 @@ GeminiRequest::~GeminiRequest()
{
}
RefPtr<Core::NetworkJob> GeminiRequest::schedule()
{
auto job = GeminiJob::construct(*this);
job->start();
return job;
}
ByteBuffer GeminiRequest::to_raw_request() const
{
StringBuilder builder;

2
Libraries/LibGemini/GeminiRequest.h
View file

@ -43,8 +43,6 @@ public:
ByteBuffer to_raw_request() const;
RefPtr<Core::NetworkJob> schedule();
static Optional<GeminiRequest> from_raw_request(const ByteBuffer&);
private:

7
Libraries/LibHTTP/HttpRequest.cpp
View file

@ -38,13 +38,6 @@ HttpRequest::~HttpRequest()
{
}
RefPtr<Core::NetworkJob> HttpRequest::schedule()
{
auto job = HttpJob::construct(*this);
job->start();
return job;
}
String HttpRequest::method_name() const
{
switch (m_method) {

2
Libraries/LibHTTP/HttpRequest.h
View file

@ -67,8 +67,6 @@ public:
String method_name() const;
ByteBuffer to_raw_request() const;
RefPtr<Core::NetworkJob> schedule();
void set_headers(const HashMap<String, String>&);
static Optional<HttpRequest> from_raw_request(const ByteBuffer&);

8
Services/ProtocolServer/HttpProtocol.cpp
View file

@ -50,10 +50,10 @@ OwnPtr<Download> HttpProtocol::start_download(ClientConnection& client, const St
request.set_url(url);
request.set_headers(headers);
request.set_body(request_body);
auto job = request.schedule();
if (!job)
return nullptr;
return HttpDownload::create_with_job({}, client, (HTTP::HttpJob&)*job);
auto job = HTTP::HttpJob::construct(request);
auto download = HttpDownload::create_with_job({}, client, (HTTP::HttpJob&)*job);
job->start();
return download;
}
}