beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Kernel: Fix reading expansion ROM SysFS node

Browse source 
Previously, reads would only be successful for offset 0. For this
reason, the maximum size that could be correctly read from the PCI
expansion ROM SysFS node was limited to the block size, and
subsequent blocks would fail. This commit fixes the computation of
the number of bytes to read.
This commit is contained in:
Robin Voetter 2023-06-18 01:48:26 +02:00 committed by Jelle Raaijmakers
parent c90136d48d
commit a433cbefbe
Notes: sideshowbarker 2024-07-17 10:31:19 +09:00 
Author: https://github.com/Snektron 🔰
Commit: https://github.com/SerenityOS/serenity/commit/a433cbefbe
Pull-request: https://github.com/SerenityOS/serenity/pull/19451
Reviewed-by: https://github.com/gmta ✅
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Kernel/FileSystem/SysFS/Subsystems/Bus/PCI/DeviceExpansionROM.cpp
View file

@ -39,12 +39,9 @@ ErrorOr<size_t> PCIDeviceExpansionROMSysFSComponent::read_bytes(off_t offset, si
if (unsigned_offset >= m_option_rom_size)
return 0;
auto blob = TRY(try_to_generate_buffer(unsigned_offset, count));
if (static_cast<size_t>(offset) >= blob->size())
return 0;
ssize_t nread = min(static_cast<off_t>(blob->size() - offset), static_cast<off_t>(count));
TRY(buffer.write(blob->data() + offset, nread));
ssize_t nread = min(static_cast<off_t>(m_option_rom_size - offset), static_cast<off_t>(count));
auto blob = TRY(try_to_generate_buffer(unsigned_offset, nread));
TRY(buffer.write(blob->bytes()));
return nread;
}