beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibTest: Return 0 if all test cases pass and 1 otherwise from TEST_MAIN

Browse source 
Before, TEST_MAIN used to return the return value of TestSuite::main()
function (which returns the number of test cases that did not pass, so
it can be >=256) directly.

The run-tests utility determines the success / failure of a test suite
binary by examining its (or i.e. TEST_MAIN's) exit status.

But as exit status values are supposed to be between 0 and 255, values
>=256 will get wrapped around (modulo 256), converting a return value of
256 to 0.

So, in a rare case where exactly 256 test cases are failing in your test
suite, run-tests utility will display that the test suite passed without
any failures.

Now, TEST_MAIN just returns 0 if all of the test cases pass and returns
1 otherwise.
This commit is contained in:
ronak69 2024-02-08 18:06:29 +00:00 committed by Jelle Raaijmakers
parent 1a223d07e1
commit a42cf020ea
Notes: sideshowbarker 2024-07-17 10:31:19 +09:00 
Author: https://github.com/ronak69
Commit: https://github.com/SerenityOS/serenity/commit/a42cf020ea
Pull-request: https://github.com/SerenityOS/serenity/pull/23126
Reviewed-by: https://github.com/ADKaster
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibTest/TestMain.cpp
View file

@ -29,5 +29,8 @@ int TEST_MAIN(int argc, char** argv)
int ret = ::Test::TestSuite::the().main(argv[0], arguments);
::Test::TestSuite::release();
return ret;
// As TestSuite::main() returns the number of test cases that did not pass,
// ret can be >=256 which cannot be returned as an exit status directly.
// Return 0 if all of the test cases pass and return 1 otherwise.
return ret != 0;
}

2
Userland/Utilities/run-tests.cpp
View file

@ -280,7 +280,7 @@ FileResult TestRunner::run_test_file(ByteString const& test_path)
break; // we'll end up with a failure
if (WIFEXITED(wstatus)) {
if (wstatus == 0) {
if (WEXITSTATUS(wstatus) == 0) {
test_result = Test::Result::Pass;
}
break;