beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Tests/Kernel: Remove redundant if (#4111)

Browse source 
Problem:

- If `fork()` fails the system tries to call `execl()`. That will
  either succeed and replace the running process image or it will fail
  and it needs to try again. The `if` is redundant because it will
  only be evaluated if `execl()` fails.

Solution:
- Remove the `if`.
This commit is contained in:
Lenny Maiorani 2020-11-29 02:41:02 -07:00 committed by GitHub
parent b9bbf377d6
commit a34939bcd5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
Notes: sideshowbarker 2024-07-19 01:12:33 +09:00 
Author: https://github.com/ldm5180
Commit: https://github.com/SerenityOS/serenity/commit/a34939bcd54
Pull-request: https://github.com/SerenityOS/serenity/pull/4111
Reviewed-by: https://github.com/alimpfard
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Userland/Tests/Kernel/elf-execve-mmap-race.cpp
View file

@ -151,8 +151,7 @@ int main()
if (!fork()) {
try_again:
printf("exec\n");
if (execl(path, "x", nullptr) < 0) {
}
execl(path, "x", nullptr);
goto try_again;
}