beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Kernel: Ignore allocation failures during thread finalization

Browse source 
We ignore allocation failures above the first 32 guaranteed thread
slots, and just flag our future-selves to finalize these threads at a
later point.
This commit is contained in:
Idan Horowitz 2022-01-26 18:34:31 +02:00 committed by Linus Groh
parent 7e9df6ddba
commit a0f404551e
Notes: sideshowbarker 2024-07-17 20:10:27 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/a0f404551e0
Pull-request: https://github.com/SerenityOS/serenity/pull/12145
Reviewed-by: https://github.com/linusg ✅
2 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Kernel/Tasks/FinalizerTask.cpp
View file

@ -14,10 +14,12 @@ static void finalizer_task(void*)
{ {
Thread::current()->set_priority(THREAD_PRIORITY_LOW); Thread::current()->set_priority(THREAD_PRIORITY_LOW);
for (;;) { for (;;) {
g_finalizer_wait_queue->wait_forever("FinalizerTask"); // The order of this if-else is important: We want to continue trying to finalize the threads in case
// Thread::finalize_dying_threads set g_finalizer_has_work back to true due to OOM conditions
if (g_finalizer_has_work.exchange(false, AK::MemoryOrder::memory_order_acq_rel) == true) if (g_finalizer_has_work.exchange(false, AK::MemoryOrder::memory_order_acq_rel) == true)
Thread::finalize_dying_threads(); Thread::finalize_dying_threads();
else
g_finalizer_wait_queue->wait_forever("FinalizerTask");
} }
}; };

9
Kernel/Thread.cpp
View file

@ -529,8 +529,13 @@ void Thread::finalize_dying_threads()
{ {
SpinlockLocker lock(g_scheduler_lock); SpinlockLocker lock(g_scheduler_lock);
for_each_in_state(Thread::State::Dying, [&](Thread& thread) { for_each_in_state(Thread::State::Dying, [&](Thread& thread) {
if (thread.is_finalizable()) if (!thread.is_finalizable())
dying_threads.append(&thread); return;
auto result = dying_threads.try_append(&thread);
// We ignore allocation failures above the first 32 guaranteed thread slots, and
// just flag our future-selves to finalize these threads at a later point
if (result.is_error())
g_finalizer_has_work.store(true, AK::MemoryOrder::memory_order_release);
}); });
} }
for (auto* thread : dying_threads) { for (auto* thread : dying_threads) {