beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibGUI: Keep still-valid indexes in selection after a model update

Browse source 
This is a stop-gap patch solution for the annoying problem of models
being bad at updating. At least the process table will retain your
selection in SystemMonitor now.
This commit is contained in:
Andreas Kling 2020-04-09 09:51:44 +02:00
parent bdb6b2ced3
commit a06548eaf7
Notes: sideshowbarker 2024-07-19 07:47:19 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/a06548eaf7b
3 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibGUI/AbstractView.cpp
View file

@ -60,10 +60,15 @@ void AbstractView::set_model(RefPtr<Model> model)
void AbstractView::did_update_model()
{
// FIXME: It's unfortunate that we lose so much view state when the model updates in any way.
stop_editing();
m_edit_index = {};
m_hovered_index = {};
selection().clear();
if (model()) {
selection().remove_matching([this](auto& index) { return !model()->is_valid(index); });
} else {
selection().clear();
}
}
void AbstractView::did_update_selection()

11
Libraries/LibGUI/ModelSelection.cpp
View file

@ -31,6 +31,17 @@
namespace GUI {
void ModelSelection::remove_matching(Function<bool(const ModelIndex&)> filter)
{
Vector<ModelIndex> to_remove;
for (auto& index : m_indexes) {
if (filter(index))
to_remove.append(index);
}
for (auto& index : to_remove)
m_indexes.remove(index);
}
void ModelSelection::set(const ModelIndex& index)
{
ASSERT(index.is_valid());

2
Libraries/LibGUI/ModelSelection.h
View file

@ -89,6 +89,8 @@ public:
return *m_indexes.begin();
}
void remove_matching(Function<bool(const ModelIndex&)>);
private:
AbstractView& m_view;
HashTable<ModelIndex> m_indexes;