beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Avoid unnecessary PropertyName creation in MarkupGenerator

Browse source
This commit is contained in:
Linus Groh 2021-07-03 22:28:40 +01:00
parent f35c25a7eb
commit 9fd9e424ff
Notes: sideshowbarker 2024-07-18 10:27:06 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/9fd9e424fff
Pull-request: https://github.com/SerenityOS/serenity/pull/8262
Reviewed-by: https://github.com/IdanHo
Reviewed-by: https://github.com/alimpfard ✅
Reviewed-by: https://github.com/awesomekling ✅
Reviewed-by: https://github.com/davidot
Reviewed-by: https://github.com/mattco98
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/MarkupGenerator.cpp
View file

@ -12,6 +12,7 @@
#include <LibJS/Runtime/Date.h>
#include <LibJS/Runtime/Error.h>
#include <LibJS/Runtime/Object.h>
#include <LibJS/Runtime/VM.h>
namespace JS {
@ -144,8 +145,9 @@ void MarkupGenerator::date_to_html(const Object& date, StringBuilder& html_outpu
void MarkupGenerator::error_to_html(const Object& object, StringBuilder& html_output, HashTable<Object*>&)
{
auto name = object.get_without_side_effects(PropertyName("name")).value_or(JS::js_undefined());
auto message = object.get_without_side_effects(PropertyName("message")).value_or(JS::js_undefined());
auto& vm = object.vm();
auto name = object.get_without_side_effects(vm.names.name).value_or(JS::js_undefined());
auto message = object.get_without_side_effects(vm.names.message).value_or(JS::js_undefined());
if (name.is_accessor() || name.is_native_property() || message.is_accessor() || message.is_native_property()) {
html_output.append(wrap_string_in_style(JS::Value(&object).to_string_without_side_effects(), StyleType::Invalid));
} else {