beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Make scrollbar thumbs visible on dark background

Browse source 
Previously, the scrollbar thumbs were (almost) invisible, when the page
background color was similar to the scrollbar thumb color (DarkGray).
Now, in addition to the filled rounded rectangle, the scrollbar thumbs
are painted with a 1px solid LightGrey border. On a white or light color
background the border stays invisible.
This commit is contained in:
simonkrauter 2024-07-13 18:01:32 -03:00 committed by Andreas Kling
parent 04526261c3
commit 9da3e29818
Notes: sideshowbarker 2024-07-17 03:00:02 +09:00 
Author: https://github.com/simonkrauter
Commit: https://github.com/LadybirdBrowser/ladybird/commit/9da3e29818
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/620
1 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Userland/Libraries/LibWeb/Painting/PaintableBox.cpp
View file

@ -340,13 +340,28 @@ void PaintableBox::paint(PaintContext& context, PaintPhase phase) const
auto scrollbar_width = computed_values().scrollbar_width();
if (phase == PaintPhase::Overlay && scrollbar_width != CSS::ScrollbarWidth::None) {
auto color = Color(Color::NamedColor::DarkGray).with_alpha(128);
auto border_color = Color(Color::NamedColor::LightGray).with_alpha(128);
auto borders_data = BordersDataDevicePixels {
.top = BorderDataDevicePixels { border_color, CSS::LineStyle::Solid, 1 },
.right = BorderDataDevicePixels { border_color, CSS::LineStyle::Solid, 1 },
.bottom = BorderDataDevicePixels { border_color, CSS::LineStyle::Solid, 1 },
.left = BorderDataDevicePixels { border_color, CSS::LineStyle::Solid, 1 },
};
int thumb_corner_radius = static_cast<int>(context.rounded_device_pixels(scrollbar_thumb_thickness / 2));
CornerRadii corner_radii = {
.top_left = Gfx::AntiAliasingPainter::CornerRadius { thumb_corner_radius, thumb_corner_radius },
.top_right = Gfx::AntiAliasingPainter::CornerRadius { thumb_corner_radius, thumb_corner_radius },
.bottom_right = Gfx::AntiAliasingPainter::CornerRadius { thumb_corner_radius, thumb_corner_radius },
.bottom_left = Gfx::AntiAliasingPainter::CornerRadius { thumb_corner_radius, thumb_corner_radius },
};
if (auto thumb_rect = scroll_thumb_rect(ScrollDirection::Horizontal); thumb_rect.has_value()) {
auto thumb_device_rect = context.enclosing_device_rect(thumb_rect.value());
paint_all_borders(context.display_list_recorder(), thumb_device_rect, corner_radii, borders_data);
context.display_list_recorder().fill_rect_with_rounded_corners(thumb_device_rect.to_type<int>(), color, thumb_corner_radius);
}
if (auto thumb_rect = scroll_thumb_rect(ScrollDirection::Vertical); thumb_rect.has_value()) {
auto thumb_device_rect = context.enclosing_device_rect(thumb_rect.value());
paint_all_borders(context.display_list_recorder(), thumb_device_rect, corner_radii, borders_data);
context.display_list_recorder().fill_rect_with_rounded_corners(thumb_device_rect.to_type<int>(), color, thumb_corner_radius);
}
}