beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Add big endian bit reading to InputBitStream

Browse source 
The existing InputBitStream methods only read in little endian, as this
is what the rest of the system requires. Two new methods allow the input
bitstream to read bits in big endian as well, while using the existing
state infrastructure.

Note that it can lead to issues if little endian and big endian reads
are used out of order without aligning to a byte boundary first.
This commit is contained in:
kleines Filmröllchen 2021-06-24 23:52:13 +02:00 committed by Ali Mohammad Pur
parent 463a645d37
commit 9d4c50ca60
Notes: sideshowbarker 2024-07-18 11:32:28 +09:00 
Author: https://github.com/kleinesfilmroellchen
Commit: https://github.com/SerenityOS/serenity/commit/9d4c50ca606
Pull-request: https://github.com/SerenityOS/serenity/pull/7111
Reviewed-by: https://github.com/alimpfard
1 changed files with 40 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
AK/BitStream.h
View file

@ -61,9 +61,9 @@ public:
return m_stream.discard_or_error(count);
}
u32 read_bits(size_t count)
u64 read_bits(size_t count)
{
u32 result = 0;
u64 result = 0;
size_t nread = 0;
while (nread < count) {
@ -88,8 +88,46 @@ public:
return result;
}
u64 read_bits_big_endian(size_t count)
{
u64 result = 0;
size_t nread = 0;
while (nread < count) {
if (m_stream.has_any_error()) {
set_fatal_error();
return 0;
}
if (m_next_byte.has_value()) {
// read an entire byte
if (((count - nread) >= 8) && m_bit_offset == 0) {
// shift existing bytes over
result <<= 8;
result |= m_next_byte.value();
nread += 8;
m_next_byte.clear();
} else {
const auto bit = (m_next_byte.value() >> (7 - m_bit_offset)) & 1;
result <<= 1;
result |= bit;
++nread;
if (m_bit_offset++ == 7)
m_next_byte.clear();
}
} else {
m_stream >> m_next_byte;
m_bit_offset = 0;
}
}
return result;
}
bool read_bit() { return static_cast<bool>(read_bits(1)); }
bool read_bit_big_endian() { return static_cast<bool>(read_bits_big_endian(1)); }
void align_to_byte_boundary()
{
if (m_next_byte.has_value())