beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 00:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

AK: Use integral power for FixedPoint formatting

Browse source 
This removes an ifdef for the Kernel
This commit is contained in:
Hendiadyoin1 2022-01-27 13:23:36 +01:00 committed by Brian Gianforcaro
parent 581c23dc55
commit 9ba9691d19
Notes: sideshowbarker 2024-07-17 19:42:30 +09:00 
Author: https://github.com/Hendiadyoin1
Commit: https://github.com/SerenityOS/serenity/commit/9ba9691d194
Pull-request: https://github.com/SerenityOS/serenity/pull/12163
Reviewed-by: https://github.com/BertalanD ✅
1 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
AK/Format.cpp
View file

@ -7,6 +7,7 @@
#include <AK/CharacterTypes.h>
#include <AK/Format.h>
#include <AK/GenericLexer.h>
#include <AK/IntegralMath.h>
#include <AK/String.h>
#include <AK/StringBuilder.h>
#include <AK/kstdio.h>
@ -383,14 +384,7 @@ ErrorOr<void> FormatBuilder::put_fixed_point(
// place to start would be the following video from CppCon 2019:
// https://youtu.be/4P_kbF0EbZM (Stephan T. Lavavej “Floating-Point <charconv>: Making Your Code 10x Faster With C++17's Final Boss”)
#ifdef KERNEL
// We don't have pow() in kernel land
u64 scale = 10;
for (size_t i = 0; i < precision - 1; i++) // TODO: not efficient
scale *= 10;
#else
u64 scale = pow(10.0, (double)precision);
#endif
u64 scale = pow<u64>(10, precision);
auto fraction = (scale * fraction_value) / fraction_one; // TODO: overflows
if (is_negative)