beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Don't assume opacity values are CSS numbers

Browse source 
...since they can also be percentages. Better to resolve them to a pair
of absolute values, and then compare those. :^)

Regressed in 921aee8c66.
This commit is contained in:
Andreas Kling 2023-07-31 08:26:30 +02:00
parent cb8664e2e1
commit 9937fcc5e1
Notes: sideshowbarker 2024-07-17 08:25:15 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/9937fcc5e1
Pull-request: https://github.com/SerenityOS/serenity/pull/20273
3 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/css/element-opacity-change-invalidation.txt Normal file
View file

@ -0,0 +1 @@
Didn't crash :^)

12
Tests/LibWeb/Text/input/css/element-opacity-change-invalidation.html Normal file
View file

@ -0,0 +1,12 @@
<script src="../include.js"></script>
<script>
test(() => {
document.body.style.opacity = '0.5';
document.body.offsetWidth
document.body.style.opacity = '100.0%';
document.body.offsetWidth
document.body.style.opacity = '0.5';
document.body.offsetWidth
println("Didn't crash :^)");
});
</script>

4
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -425,8 +425,8 @@ static Element::RequiredInvalidationAfterStyleChange compute_required_invalidati
// OPTIMIZATION: An element creates a stacking context when its opacity changes from 1 to less than 1
// and stops to create one when opacity returns to 1. So stacking context tree rebuild is
// not required for opacity changes within the range below 1.
auto old_value_opacity = old_value.has_value() ? old_value->style->as_number().number() : 1;
auto new_value_opacity = new_value.has_value() ? new_value->style->as_number().number() : 1;
auto old_value_opacity = old_style.opacity();
auto new_value_opacity = new_style.opacity();
if (old_value_opacity != new_value_opacity && (old_value_opacity == 1 || new_value_opacity == 1)) {
invalidation.rebuild_stacking_context_tree = true;
}