beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Everywhere: Add break after the last case label before default

Browse source 
We already do this in most places, so the style should be consistent.
Also, Clang does not like it, as this could cause an unexpected compile
error if some statements are added to the default label or a new label
is added above it.
This commit is contained in:
Daniel Bertalan 2021-07-05 19:17:08 +02:00 committed by Gunnar Beutner
parent b0208ce433
commit 98a9a1d7f9
Notes: sideshowbarker 2024-07-18 10:05:56 +09:00 
Author: https://github.com/BertalanD
Commit: https://github.com/SerenityOS/serenity/commit/98a9a1d7f92
Pull-request: https://github.com/SerenityOS/serenity/pull/8470
Reviewed-by: https://github.com/Dexesttp
Reviewed-by: https://github.com/Hendiadyoin1
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/gunnarbeutner ✅
7 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Userland/DevTools/Profiler/TimelineTrack.cpp
View file

@ -41,6 +41,7 @@ void TimelineTrack::event(Core::Event& event)
case GUI::Event::MouseDown:
case GUI::Event::MouseMove:
event.ignore();
break;
default:
break;
}

2
Userland/Libraries/LibGUI/ColumnsView.cpp
View file

@ -298,8 +298,8 @@ void ColumnsView::move_cursor(CursorMovement movement, SelectionUpdate selection
if (model.is_valid(cursor_index()))
push_column(cursor_index());
update();
break;
}
break;
default:
break;
}

1
Userland/Libraries/LibWeb/CSS/StyleResolver.cpp
View file

@ -244,6 +244,7 @@ static void set_property_expanding_shorthands(StyleProperties& style, CSS::Prope
case CSS::ValueID::LineThrough:
case CSS::ValueID::Blink:
set_property_expanding_shorthands(style, CSS::PropertyID::TextDecorationLine, value, document);
break;
default:
break;
}

1
Userland/Services/Taskbar/TaskbarWindow.cpp
View file

@ -345,6 +345,7 @@ void TaskbarWindow::wm_event(GUI::WMEvent& event)
case GUI::Event::WM_VirtualDesktopChanged: {
auto& changed_event = static_cast<GUI::WMVirtualDesktopChangedEvent&>(event);
virtual_desktop_change_event(changed_event.current_row(), changed_event.current_column());
break;
}
default:
break;

1
Userland/Utilities/du.cpp
View file

@ -184,6 +184,7 @@ int print_space_usage(const String& path, const DuOption& du_option, int max_dep
break;
case DuOption::TimeType::Status:
time = path_stat.st_ctime;
break;
default:
break;
}

1
Userland/Utilities/js.cpp
View file

@ -963,6 +963,7 @@ int main(int argc, char** argv)
break;
case JS::TokenCategory::Identifier:
stylize({ start, end }, { Line::Style::Foreground(Line::Style::XtermColor::White), Line::Style::Bold });
break;
default:
break;
}

1
Userland/Utilities/sql.cpp
View file

@ -165,6 +165,7 @@ int main()
break;
case SQL::AST::TokenCategory::Identifier:
editor.stylize({ start, end }, { Line::Style::Foreground(Line::Style::XtermColor::White), Line::Style::Bold });
break;
default:
break;
}