beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-01 12:00:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

WindowServer: Don't try to load unspecified icons

Browse source 
Some apps (looking at you, VisualBuilder) don't specify an icon
in their .af file, so WindowServer was trying to open an empty path.
That made it print a perror message to the log each time. Let's not
do that ^)
This commit is contained in:
Sergey Bugaev 2020-02-07 12:29:37 +03:00 committed by Andreas Kling
parent 982eb996f7
commit 960df8a62a
Notes: sideshowbarker 2024-07-19 09:32:59 +09:00 
Author: https://github.com/bugaevc
Commit: https://github.com/SerenityOS/serenity/commit/960df8a62a3
Pull-request: https://github.com/SerenityOS/serenity/pull/1191
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Servers/WindowServer/MenuManager.cpp
View file

@ -102,8 +102,12 @@ MenuManager::MenuManager()
// Then we create and insert all the app menu items into the right place.
int app_identifier = 1;
for (const auto& app : m_apps) {
RefPtr<Gfx::Bitmap> icon;
if (!app.icon_path.is_empty())
icon = Gfx::Bitmap::load_from_file(app.icon_path);
auto parent_menu = m_app_category_menus.get(app.category).value_or(*m_system_menu);
parent_menu->add_item(make<MenuItem>(*m_system_menu, app_identifier++, app.name, String(), true, false, false, Gfx::Bitmap::load_from_file(app.icon_path)));
parent_menu->add_item(make<MenuItem>(*m_system_menu, app_identifier++, app.name, String(), true, false, false, icon));
}
m_system_menu->add_item(make<MenuItem>(*m_system_menu, MenuItem::Separator));