beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 00:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

AK: Make all HashMap copy-constructs explicit

Browse source
This commit is contained in:
Ben Wiederhake 2023-05-13 20:26:20 +02:00 committed by Jelle Raaijmakers
parent 6421899078
commit 95d90a760b
Notes: sideshowbarker 2024-07-17 18:38:54 +09:00 
Author: https://github.com/BenWiederhake
Commit: https://github.com/SerenityOS/serenity/commit/95d90a760b
Pull-request: https://github.com/SerenityOS/serenity/pull/18821
Reviewed-by: https://github.com/awesomekling
Reviewed-by: https://github.com/gmta ✅
Reviewed-by: https://github.com/kleinesfilmroellchen ✅
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
AK/JsonObject.cpp
View file

@ -14,7 +14,7 @@ JsonObject::JsonObject() = default;
JsonObject::~JsonObject() = default;
JsonObject::JsonObject(JsonObject const& other)
: m_members(other.m_members)
: m_members(other.m_members.clone().release_value_but_fixme_should_propagate_errors())
{
}
@ -26,7 +26,7 @@ JsonObject::JsonObject(JsonObject&& other)
JsonObject& JsonObject::operator=(JsonObject const& other)
{
if (this != &other)
m_members = other.m_members;
m_members = other.m_members.clone().release_value_but_fixme_should_propagate_errors();
return *this;
}

2
AK/SourceGenerator.h
View file

@ -27,7 +27,7 @@ public:
}
explicit SourceGenerator(StringBuilder& builder, MappingType const& mapping, char opening = '@', char closing = '@')
: m_builder(builder)
, m_mapping(mapping)
, m_mapping(mapping.clone().release_value_but_fixme_should_propagate_errors())
, m_opening(opening)
, m_closing(closing)
{