beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 09:00:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibJS: Add to_string definitions to CodeGenerationError and ParserError

Browse source
This commit is contained in:
Timothy Flynn 2023-02-16 11:03:49 -05:00 committed by Tim Flynn
parent f7458b3e17
commit 93ad25fbe5
Notes: sideshowbarker 2024-07-17 06:46:15 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/93ad25fbe5
Pull-request: https://github.com/SerenityOS/serenity/pull/17494
Reviewed-by: https://github.com/linusg ✅
5 changed files with 30 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
Userland/Libraries/LibJS/Bytecode/CodeGenerationError.cpp Normal file
View file

@ -0,0 +1,17 @@
/*
* Copyright (c) 2023, Tim Flynn <trflynn89@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibJS/AST.h>
#include <LibJS/Bytecode/CodeGenerationError.h>
namespace JS::Bytecode {
ErrorOr<String> CodeGenerationError::to_string() const
{
return String::formatted("CodeGenerationError in {}: {}", failing_node ? failing_node->class_name() : "<unknown node>", reason_literal);
}
}

2
Userland/Libraries/LibJS/Bytecode/CodeGenerationError.h
View file

@ -7,6 +7,7 @@
#pragma once
#include <AK/Error.h>
#include <AK/String.h>
#include <AK/StringView.h>
#include <LibJS/Forward.h>
@ -16,6 +17,7 @@ struct CodeGenerationError {
ASTNode const* failing_node { nullptr };
StringView reason_literal;
ErrorOr<String> to_string() const;
DeprecatedString to_deprecated_string();
};

1
Userland/Libraries/LibJS/CMakeLists.txt
View file

@ -2,6 +2,7 @@ set(SOURCES
AST.cpp
Bytecode/ASTCodegen.cpp
Bytecode/BasicBlock.cpp
Bytecode/CodeGenerationError.cpp
Bytecode/Executable.cpp
Bytecode/Generator.cpp
Bytecode/IdentifierTable.cpp

7
Userland/Libraries/LibJS/ParserError.cpp
View file

@ -12,6 +12,13 @@
namespace JS {
ErrorOr<String> ParserError::to_string() const
{
if (!position.has_value())
return String::from_deprecated_string(message);
return String::formatted("{} (line: {}, column: {})", message, position.value().line, position.value().column);
}
DeprecatedString ParserError::to_deprecated_string() const
{
if (!position.has_value())

3
Userland/Libraries/LibJS/ParserError.h
View file

@ -8,7 +8,9 @@
#pragma once
#include <AK/DeprecatedString.h>
#include <AK/Error.h>
#include <AK/Optional.h>
#include <AK/String.h>
#include <LibJS/SourceRange.h>
namespace JS {
@ -17,6 +19,7 @@ struct ParserError {
DeprecatedString message;
Optional<Position> position;
ErrorOr<String> to_string() const;
DeprecatedString to_deprecated_string() const;
DeprecatedString source_location_hint(StringView source, char const spacer = ' ', char const indicator = '^') const;
};