beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

RequestServer: Actually hold on to the preload job until it's done

Browse source 
This was some nonsense code left in by mistake, ref commit:
4211639e45

Fixes #904.
This commit is contained in:
Ali Mohammad Pur 2024-07-30 16:08:37 +02:00 committed by Tim Flynn
parent b445b907a1
commit 93216a875e
Notes: github-actions[bot] 2024-07-30 16:04:27 +00:00 
Author: https://github.com/alimpfard
Commit: https://github.com/LadybirdBrowser/ladybird/commit/93216a875eb
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/905
Reviewed-by: https://github.com/trflynn89 ✅
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Userland/Services/RequestServer/ConnectionCache.h
View file

@ -100,8 +100,7 @@ struct JobData {
}
#endif
template<typename T>
static JobData create(WeakPtr<T> job, [[maybe_unused]] URL::URL url)
static JobData create(auto job, [[maybe_unused]] URL::URL url)
{
return JobData {
[job](auto& socket) { job->start(socket); },

2
Userland/Services/RequestServer/ConnectionFromClient.cpp
View file

@ -162,7 +162,7 @@ void ConnectionFromClient::worker_do_work(Work work)
dbgln("EnsureConnection: Pre-connect to {}", url);
auto do_preconnect = [=, job = Job::ensure(url)](auto& cache) {
ConnectionCache::ensure_connection(cache, url, job->make_weak_ptr<Job>());
ConnectionCache::ensure_connection(cache, url, move(job));
};
if (url.scheme() == "http"sv)