beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Kernel: Fix usermode verification in ptrace with PT_SETREGS

Browse source 
When doing PT_SETREGS, we want to verify that the debugged thread is
executing in usermode.

b2f7ccf refactored things and flipped the relevant check around, which
broke things that use PT_SETREGS (for example, stepping over
breakpoints with sdb).
This commit is contained in:
Itamar 2023-02-03 16:22:16 +02:00 committed by Jelle Raaijmakers
parent 85ca19ffd5
commit 8fce807b10
Notes: sideshowbarker 2024-07-17 05:02:42 +09:00 
Author: https://github.com/itamar8910
Commit: https://github.com/SerenityOS/serenity/commit/8fce807b10
Pull-request: https://github.com/SerenityOS/serenity/pull/17296
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Syscalls/ptrace.cpp
View file

@ -107,7 +107,7 @@ static ErrorOr<FlatPtr> handle_ptrace(Kernel::Syscall::SC_ptrace_params const& p
auto& peer_saved_registers = peer->get_register_dump_from_stack();
// Verify that the saved registers are in usermode context
if (peer_saved_registers.previous_mode() == ExecutionMode::User)
if (peer_saved_registers.previous_mode() != ExecutionMode::User)
return EFAULT;
tracer->set_regs(regs);