beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Add a helper class to work around empty execution context stack

Browse source 
We've peppered this workaround around the code base as needed in a few
different ways. This adds a helper class to perform this workaround in
order to simplify doing so, and ensure cleanup occurs in a RAII fashion.
This also makes it easier to grep for places where this workaround is
employed.
This commit is contained in:
Timothy Flynn 2023-07-06 07:37:29 -04:00 committed by Tim Flynn
parent 10edd38543
commit 8ec7b4401a
Notes: sideshowbarker 2024-07-18 00:54:03 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/8ec7b4401a
Pull-request: https://github.com/SerenityOS/serenity/pull/19840
Reviewed-by: https://github.com/linusg ✅
3 changed files with 49 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibWeb/CMakeLists.txt
View file

@ -363,6 +363,7 @@ set(SOURCES
HTML/Scripting/ModuleMap.cpp
HTML/Scripting/ModuleScript.cpp
HTML/Scripting/Script.cpp
HTML/Scripting/TemporaryExecutionContext.cpp
HTML/Scripting/WindowEnvironmentSettingsObject.cpp
HTML/SessionHistoryEntry.cpp
HTML/SharedImageRequest.cpp

23
Userland/Libraries/LibWeb/HTML/Scripting/TemporaryExecutionContext.cpp Normal file
View file

@ -0,0 +1,23 @@
/*
* Copyright (c) 2023, Tim Flynn <trflynn89@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibWeb/HTML/Scripting/Environments.h>
#include <LibWeb/HTML/Scripting/TemporaryExecutionContext.h>
namespace Web::HTML {
TemporaryExecutionContext::TemporaryExecutionContext(EnvironmentSettingsObject& environment_settings)
: m_environment_settings(environment_settings)
{
m_environment_settings.prepare_to_run_script();
}
TemporaryExecutionContext::~TemporaryExecutionContext()
{
m_environment_settings.clean_up_after_running_script();
}
}

25
Userland/Libraries/LibWeb/HTML/Scripting/TemporaryExecutionContext.h Normal file
View file

@ -0,0 +1,25 @@
/*
* Copyright (c) 2023, Tim Flynn <trflynn89@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <LibWeb/Forward.h>
namespace Web::HTML {
// When JS is run from outside the context of any user script, we currently do not have a running execution context.
// This results in a crash when we access VM::running_execution_context(). This is a spec issue. Until it is resolved,
// this is a workaround to temporarily push an execution context.
class TemporaryExecutionContext {
public:
explicit TemporaryExecutionContext(EnvironmentSettingsObject&);
~TemporaryExecutionContext();
private:
EnvironmentSettingsObject& m_environment_settings;
};
}