beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 17:40:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Increase the transient activation duration from 5ms to 5s

Browse source 
It seems we were errantly mixing seconds and milliseconds in this
transient activation timeout. Increase it to 5 seconds, and be explicit
about its type - DOMHighResTimeStamp is by definition milliseconds.
This commit is contained in:
Timothy Flynn 2024-02-24 16:27:17 -05:00 committed by Tim Flynn
parent 83128d093e
commit 8d7a5afe58
Notes: sideshowbarker 2024-07-17 05:00:08 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/8d7a5afe58
Pull-request: https://github.com/SerenityOS/serenity/pull/23336
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/nico
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/Window.cpp
View file

@ -604,7 +604,7 @@ bool Window::has_transient_activation() const
{
// The transient activation duration is expected be at most a few seconds, so that the user can possibly
// perceive the link between an interaction with the page and the page calling the activation-gated API.
auto transient_activation_duration = 5;
static constexpr HighResolutionTime::DOMHighResTimeStamp transient_activation_duration_ms = 5000;
// AD-HOC: Due to resource limitations on CI, we cannot rely on the time between the activation timestamp and the
// transient activation timeout being predictable. So we allow tests to indicate when they want the next
@ -621,7 +621,7 @@ bool Window::has_transient_activation() const
// is greater than or equal to the last activation timestamp in W
if (current_time >= m_last_activation_timestamp) {
// and less than the last activation timestamp in W plus the transient activation duration
if (current_time < m_last_activation_timestamp + transient_activation_duration) {
if (current_time < m_last_activation_timestamp + transient_activation_duration_ms) {
// then W is said to have transient activation.
return true;
}