beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Parse "none" value for box-shadow property

Browse source 
Previously, `box-shadow: none` would fail to parse, meaning that in this
example:

```css
p {
  box-shadow: 20px 10px 5px magenta;
}

p.foo {
  box-shadow: none;
}
```

... a `<p class="foo">` would still have a box-shadow, when it should
not have one. Now, we handle the `none` value. :^)
This commit is contained in:
Sam Atkins 2021-10-15 19:25:27 +01:00 committed by Linus Groh
parent 7879b98f60
commit 8b57e56d66
Notes: sideshowbarker 2024-07-18 02:20:08 +09:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/SerenityOS/serenity/commit/8b57e56d662
Pull-request: https://github.com/SerenityOS/serenity/pull/10490
2 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -2571,6 +2571,13 @@ RefPtr<StyleValue> Parser::parse_border_radius_shorthand_value(ParsingContext co
RefPtr<StyleValue> Parser::parse_box_shadow_value(ParsingContext const& context, Vector<StyleComponentValueRule> const& component_values)
{
// "none"
if (component_values.size() == 1 && component_values.first().is(Token::Type::Ident)) {
auto ident = parse_identifier_value(context, component_values.first());
if (ident && ident->to_identifier() == ValueID::None)
return ident;
}
// FIXME: Also support inset, spread-radius and multiple comma-separated box-shadows
Length offset_x {};
Length offset_y {};

5
Userland/Libraries/LibWeb/CSS/Properties.json
View file

@ -415,7 +415,10 @@
},
"box-shadow": {
"inherited": false,
"initial": "none"
"initial": "none",
"valid-identifiers": [
"none"
]
},
"box-sizing": {
"inherited": false,