beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 17:10:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

WebContent: Return errors from unimplemented WebDriver endpoints

Browse source 
Previously, some otherwise unimplemented WebDriver endpoints were
indicating that they had executed successful, this was causing a large
number of Web Platform Tests to time out when they should have failed.
This commit is contained in:
Tim Ledbetter 2024-09-22 18:43:11 +01:00 committed by Tim Flynn
parent 583eef265f
commit 8939ae8522
Notes: github-actions[bot] 2024-09-23 12:44:09 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/8939ae85224
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1499
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Userland/Services/WebContent/WebDriverConnection.cpp
View file

@ -1523,7 +1523,7 @@ Messages::WebDriverClient::ElementClearResponse WebDriverConnection::element_cle
// FIXME: 12. Return success with data null.
return JsonValue {};
return Web::WebDriver::Error::from_code(Web::WebDriver::ErrorCode::UnsupportedOperation, "element clear not implemented"sv);
}
// 12.5.3 Element Send Keys, https://w3c.github.io/webdriver/#dfn-element-send-keys
@ -1749,7 +1749,7 @@ Messages::WebDriverClient::ElementSendKeysResponse WebDriverConnection::element_
// FIXME: 15. Return success with data null.
return JsonValue {};
return Web::WebDriver::Error::from_code(Web::WebDriver::ErrorCode::UnsupportedOperation, "send keys not implemented"sv);
}
// 13.1 Get Page Source, https://w3c.github.io/webdriver/#dfn-get-page-source
@ -2046,8 +2046,8 @@ Messages::WebDriverClient::PerformActionsResponse WebDriverConnection::perform_a
// FIXME: 6. Dispatch actions with input state, actions by tick, current browsing context, and actions options. If this results in an error return that error.
// 7. Return success with data null.
return JsonValue {};
// FIXME: 7. Return success with data null.
return Web::WebDriver::Error::from_code(Web::WebDriver::ErrorCode::UnsupportedOperation, "perform actions not implemented"sv);
}
// 15.8 Release Actions, https://w3c.github.io/webdriver/#release-actions