beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Mark Error::from_ functions as [[nodiscard]]

Browse source 
Prevents mistakes like the one fixed in #16672.
This commit is contained in:
Nico Weber 2022-12-26 09:17:22 -05:00 committed by Tim Flynn
parent c96e663b0a
commit 8932b28b8a
Notes: sideshowbarker 2024-07-17 02:59:43 +09:00 
Author: https://github.com/nico
Commit: https://github.com/SerenityOS/serenity/commit/8932b28b8a
Pull-request: https://github.com/SerenityOS/serenity/pull/16673
Reviewed-by: https://github.com/trflynn89 ✅
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
AK/Error.h
View file

@ -21,9 +21,9 @@ namespace AK {
class Error {
public:
static Error from_errno(int code) { return Error(code); }
static Error from_syscall(StringView syscall_name, int rc) { return Error(syscall_name, rc); }
static Error from_string_view(StringView string_literal) { return Error(string_literal); }
[[nodiscard]] static Error from_errno(int code) { return Error(code); }
[[nodiscard]] static Error from_syscall(StringView syscall_name, int rc) { return Error(syscall_name, rc); }
[[nodiscard]] static Error from_string_view(StringView string_literal) { return Error(string_literal); }
// NOTE: Prefer `from_string_literal` when directly typing out an error message:
//
@ -32,7 +32,7 @@ public:
// If you need to return a static string based on a dynamic condition (like
// picking an error from an array), then prefer `from_string_view` instead.
template<size_t N>
ALWAYS_INLINE static Error from_string_literal(char const (&string_literal)[N])
[[nodiscard]] ALWAYS_INLINE static Error from_string_literal(char const (&string_literal)[N])
{
return from_string_view(StringView { string_literal, N - 1 });
}