beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 00:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

AK: Add Array::contains_slow() and ::first_index_of(), with tests :^)

Browse source
This commit is contained in:
Sam Atkins 2023-04-21 11:21:47 +01:00 committed by Linus Groh
parent 955528055c
commit 892470a912
Notes: sideshowbarker 2024-07-17 02:59:43 +09:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/SerenityOS/serenity/commit/892470a912
Pull-request: https://github.com/SerenityOS/serenity/pull/18441
Reviewed-by: https://github.com/linusg
Reviewed-by: https://github.com/nico
Reviewed-by: https://github.com/trflynn89
2 changed files with 33 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
AK/Array.h
View file

@ -7,6 +7,7 @@
#pragma once
#include <AK/Iterator.h>
#include <AK/Optional.h>
#include <AK/Span.h>
#include <AK/StdLibExtras.h>
#include <AK/TypedTransfer.h>
@ -119,6 +120,20 @@ struct Array {
return value;
}
bool contains_slow(T const& value) const
{
return first_index_of(value).has_value();
}
Optional<size_t> first_index_of(T const& value) const
{
for (size_t i = 0; i < Size; ++i) {
if (__data[i] == value)
return i;
}
return {};
}
Conditional<Size == 0, Detail::EmptyArrayStorage<T>, T[Size]> __data;
};

18
Tests/AK/TestArray.cpp
View file

@ -28,3 +28,21 @@ TEST_CASE(compile_time_iterable)
constexpr Array<int, 8> array = { 0, 1, 2, 3, 4, 5, 6, 7 };
static_assert(constexpr_sum(array) == 28);
}
TEST_CASE(contains_slow)
{
constexpr Array<int, 8> array = { 0, 1, 2, 3, 4, 5, 6, 7 };
EXPECT(array.contains_slow(0));
EXPECT(array.contains_slow(4));
EXPECT(array.contains_slow(7));
EXPECT(!array.contains_slow(42));
}
TEST_CASE(first_index_of)
{
constexpr Array<int, 8> array = { 0, 1, 2, 3, 4, 5, 6, 7 };
EXPECT(array.first_index_of(0) == 0u);
EXPECT(array.first_index_of(4) == 4u);
EXPECT(array.first_index_of(7) == 7u);
EXPECT(!array.first_index_of(42).has_value());
}