beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 15:10:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Stop exporting AK::FixedPoint into the global namespace

Browse source 
This declaration has conflicts with the macOS SDK, which becomes a
problem when trying to interact with system clang modules.
This commit is contained in:
Andrew Kaster 2024-07-16 23:48:46 -06:00 committed by Sam Atkins
parent 1529f5469c
commit 88044f59c6
Notes: sideshowbarker 2024-07-18 23:46:25 +09:00 
Author: https://github.com/ADKaster
Commit: https://github.com/LadybirdBrowser/ladybird/commit/88044f59c6c
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/676
Reviewed-by: https://github.com/AtkinsSJ ✅
Reviewed-by: https://github.com/trflynn89 ✅
3 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
AK/FixedPoint.h
View file

@ -480,7 +480,3 @@ struct Formatter<FixedPoint<precision, Underlying>> : StandardFormatter {
}; };
} }
#if USING_AK_GLOBALLY
using AK::FixedPoint;
#endif

1
AK/Forward.h
View file

@ -160,7 +160,6 @@ using AK::DoublyLinkedList;
using AK::Error; using AK::Error;
using AK::ErrorOr; using AK::ErrorOr;
using AK::FixedArray; using AK::FixedArray;
using AK::FixedPoint;
using AK::FlyString; using AK::FlyString;
using AK::Function; using AK::Function;
using AK::GenericLexer; using AK::GenericLexer;

2
Tests/AK/TestFixedPoint.cpp
View file

@ -9,6 +9,8 @@
#include <AK/FixedPoint.h> #include <AK/FixedPoint.h>
#include <AK/NumericLimits.h> #include <AK/NumericLimits.h>
using AK::FixedPoint;
using Type = FixedPoint<4>; using Type = FixedPoint<4>;
TEST_CASE(arithmetic) TEST_CASE(arithmetic)