LibCore: Make Process::wait_for_termination return exit code

Author: https://github.com/stasoid
Commit: https://github.com/LadybirdBrowser/ladybird/commit/866609c682e
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2377
Reviewed-by: https://github.com/ADKaster ✅

Libraries/LibCore/Process.cpp

@@ -335,19 +335,19 @@ ErrorOr<void> Process::disown()
     }
 }
 
-ErrorOr<bool> Process::wait_for_termination()
+ErrorOr<int> Process::wait_for_termination()
 {
     VERIFY(m_pid > 0);
 
-    bool exited_with_code_0 = true;
+    int exit_code = -1;
     int status;
     if (waitpid(m_pid, &status, 0) == -1)
         return Error::from_syscall("waitpid"sv, errno);
 
     if (WIFEXITED(status)) {
-        exited_with_code_0 &= WEXITSTATUS(status) == 0;
+        exit_code = WEXITSTATUS(status);
     } else if (WIFSIGNALED(status)) {
-        exited_with_code_0 = false;
+        exit_code = 128 + WTERMSIG(status);
     } else if (WIFSTOPPED(status)) {
         // This is only possible if the child process is being traced by us.
         VERIFY_NOT_REACHED();
@@ -356,7 +356,7 @@ ErrorOr<bool> Process::wait_for_termination()
     }
 
     m_should_disown = false;
-    return exited_with_code_0;
+    return exit_code;
 }
 
 }

Libraries/LibCore/Process.h

@@ -79,8 +79,7 @@ public:
     ErrorOr<void> disown();
 #endif
 
-    // FIXME: Make it return an exit code.
-    ErrorOr<bool> wait_for_termination();
+    ErrorOr<int> wait_for_termination();
 
 private:
 #ifndef AK_OS_WINDOWS

Libraries/LibCore/ProcessWindows.cpp

@@ -146,7 +146,7 @@ pid_t Process::pid() const
     return GetProcessId(m_handle);
 }
 
-ErrorOr<bool> Process::wait_for_termination()
+ErrorOr<int> Process::wait_for_termination()
 {
     auto result = WaitForSingleObject(m_handle, INFINITE);
     if (result == WAIT_FAILED)
@@ -156,7 +156,7 @@ ErrorOr<bool> Process::wait_for_termination()
     if (!GetExitCodeProcess(m_handle, &exit_code))
         return Error::from_windows_error(GetLastError());
 
-    return !exit_code;
+    return exit_code;
 }
 
 }