beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibGUI: Use normalized TextRange for early empty string check

Browse source 
Fixes #6141. Allows to copy "backward" selections.
This commit is contained in:
Maciej Zygmanowski 2021-04-05 15:34:39 +02:00 committed by Andreas Kling
parent 1f65c2a981
commit 8646f8f4ad
Notes: sideshowbarker 2024-07-18 20:45:51 +09:00 
Author: https://github.com/sppmacd
Commit: https://github.com/SerenityOS/serenity/commit/8646f8f4ad3
Pull-request: https://github.com/SerenityOS/serenity/pull/6142
Issue: https://github.com/SerenityOS/serenity/issues/6141
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibGUI/TextDocument.cpp
View file

@ -343,9 +343,9 @@ String TextDocument::text() const
String TextDocument::text_in_range(const TextRange& a_range) const
{
if (is_empty() || line_count() < a_range.end().line() - a_range.start().line() || line(a_range.start().line()).is_empty())
return String("");
auto range = a_range.normalized();
if (is_empty() || line_count() < range.end().line() - range.start().line() || line(range.start().line()).is_empty())
return String("");
StringBuilder builder;
for (size_t i = range.start().line(); i <= range.end().line(); ++i) {