beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Use Element::id() in SelectorEngine

Browse source 
This makes ID selector matching O(1) instead of O(n).
This commit is contained in:
Andreas Kling 2023-11-02 14:57:40 +01:00
parent 1c62ee9396
commit 83c3490bc4
Notes: sideshowbarker 2024-07-17 00:37:23 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/83c3490bc4
Pull-request: https://github.com/SerenityOS/serenity/pull/21746
Reviewed-by: https://github.com/AtkinsSJ ✅
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/CSS/SelectorEngine.cpp
View file

@ -583,7 +583,7 @@ static inline bool matches(CSS::Selector::SimpleSelector const& component, Optio
VERIFY_NOT_REACHED();
}
case CSS::Selector::SimpleSelector::Type::Id:
return component.name() == element.deprecated_attribute(HTML::AttributeNames::id).view();
return component.name() == element.id();
case CSS::Selector::SimpleSelector::Type::Class:
return element.has_class(component.name());
case CSS::Selector::SimpleSelector::Type::Attribute: