beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Adjust ref-tests to reduce flakiness

Browse source 
These two ref-tests involve two boxes positioned in the same place, with
outlines. Outlines always have a border-radius, meaning that the corner
pixels are not 100% opaque. (It seems to be 254 instead of 255.) With
the test files painting two outlines, and the ref test only painting
one, slight changes in the background color of the page would make that
slight variation visible sometimes. So, let's avoid that inconsistency
by always painting one outline instead of two.
This commit is contained in:
Sam Atkins 2023-08-24 12:01:28 +01:00 committed by Sam Atkins
parent ad5df3bef8
commit 82ccc49b52
Notes: sideshowbarker 2024-07-17 01:10:58 +09:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/SerenityOS/serenity/commit/82ccc49b52
Pull-request: https://github.com/SerenityOS/serenity/pull/20740
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibWeb/Ref/grid-items-painting-order-ref.html
View file

@ -1,7 +1,7 @@
<!doctype html><style type="text/css">
* { outline: 1px solid black; }
body { display: grid; }
.bar {
outline: 1px solid black;
grid-area: 1 / 1 / auto / auto;
background: orange;
}

2
Tests/LibWeb/Ref/grid-items-painting-order.html
View file

@ -1,11 +1,11 @@
<!doctype html><style type="text/css">
* { outline: 1px solid black; }
body { display: grid; }
.foo {
grid-area: 1 / 1 / auto / auto;
background: pink;
}
.bar {
outline: 1px solid black;
grid-area: 1 / 1 / auto / auto;
background: orange;
}

2
Tests/LibWeb/Ref/item-with-negative-z-index-ref.html
View file

@ -1,7 +1,7 @@
<!doctype html><style type="text/css">
* { outline: 1px solid black; }
body { display: grid; }
.foo {
outline: 1px solid black;
grid-area: 1 / 1 / auto / auto;
background: pink;
}

2
Tests/LibWeb/Ref/item-with-negative-z-index.html
View file

@ -1,7 +1,7 @@
<!doctype html><style type="text/css">
* { outline: 1px solid black; }
body { display: grid; }
.foo {
outline: 1px solid black;
grid-area: 1 / 1 / auto / auto;
background: pink;
}