beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Toolchain: Remove git clone of project from Dockerfile

Browse source 
The goal of these more recent additions to the Dockerfile is to provide
a working copy of SerenityOS with the toolchain prebuilt. To me, these
additions feel misplaced:

- The toolchain is built assuming the i686 architecture, which may not
  be what you want.
- You get a shallow clone of the project limiting you in your abilities
  to navigate through the project's history or bisect.
- There's this awkward directory structure of `/serenity/serenity-git`
  and `/serenity/out`.

The Dockerfile is immensely useful for building SerenityOS in a
containerized environment, separate from the host's environment. If we
want to automate builds, we can always use CI or extend this image to
do so. For now, let's remove the `git clone` and associated actions.

Fixes #9310.
This commit is contained in:
Jelle Raaijmakers 2021-11-17 01:22:11 +01:00 committed by Linus Groh
parent cff3add897
commit 8292061f53
Notes: sideshowbarker 2024-07-18 00:57:35 +09:00 
Author: https://github.com/gmta
Commit: https://github.com/SerenityOS/serenity/commit/8292061f53a
Pull-request: https://github.com/SerenityOS/serenity/pull/10941
Reviewed-by: https://github.com/ADKaster ✅
Reviewed-by: https://github.com/kleinesfilmroellchen ✅
1 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Toolchain/Dockerfile
View file

@ -29,10 +29,3 @@ RUN apt-get update -y \
unzip \
&& rm -rf /var/lib/apt/lists/ \
&& update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 900 --slave /usr/bin/g++ g++ /usr/bin/g++-10
RUN git clone --depth 1 https://github.com/SerenityOS/serenity.git /serenity/serenity-git
RUN cd /serenity/serenity-git/Toolchain; \
./BuildIt.sh
WORKDIR /serenity
VOLUME /serenity/out