beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibGfx/ExifOrientedBitmap: Reorganize create parameters

Browse source 
No behavior change.
This commit is contained in:
Lucas CHOLLET 2024-01-18 18:51:31 -05:00 committed by Andrew Kaster
parent 09b2b3539b
commit 8229a19081
Notes: sideshowbarker 2024-07-17 01:10:58 +09:00 
Author: https://github.com/LucasChollet
Commit: https://github.com/SerenityOS/serenity/commit/8229a19081
Pull-request: https://github.com/SerenityOS/serenity/pull/22856
Reviewed-by: https://github.com/ADKaster ✅
Reviewed-by: https://github.com/nico ✅
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGfx/ImageFormats/ExifOrientedBitmap.h
View file

@ -14,7 +14,7 @@ namespace Gfx {
class ExifOrientedBitmap {
public:
template<typename... Args>
static ErrorOr<ExifOrientedBitmap> create(BitmapFormat format, IntSize size, TIFF::Orientation orientation)
static ErrorOr<ExifOrientedBitmap> create(TIFF::Orientation orientation, IntSize size, BitmapFormat format)
{
auto bitmap = TRY(Bitmap::create(format, oriented_size(size, orientation)));
return ExifOrientedBitmap(move(bitmap), size, orientation);

2
Userland/Libraries/LibGfx/ImageFormats/JPEGXLLoader.cpp
View file

@ -1719,7 +1719,7 @@ public:
auto const height = m_channels[0].height();
auto const orientation = static_cast<TIFF::Orientation>(metadata.orientation);
auto oriented_bitmap = TRY(ExifOrientedBitmap::create(BitmapFormat::BGRA8888, { width, height }, orientation));
auto oriented_bitmap = TRY(ExifOrientedBitmap::create(orientation, { width, height }, BitmapFormat::BGRA8888));
auto const alpha_channel = metadata.alpha_channel();

2
Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.cpp
View file

@ -243,7 +243,7 @@ private:
auto const strip_byte_counts = *m_metadata.strip_byte_counts();
auto const rows_per_strip = m_metadata.rows_per_strip().value_or(*m_metadata.image_height());
auto oriented_bitmap = TRY(ExifOrientedBitmap::create(BitmapFormat::BGRA8888, { *metadata().image_width(), *metadata().image_height() }, *metadata().orientation()));
auto oriented_bitmap = TRY(ExifOrientedBitmap::create(*metadata().orientation(), { *metadata().image_width(), *metadata().image_height() }, BitmapFormat::BGRA8888));
for (u32 strip_index = 0; strip_index < strips_offset.size(); ++strip_index) {
TRY(m_stream->seek(strips_offset[strip_index]));