beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Catch null browsing context in destroy_top_level_traversable

Browse source 
When WebDriver asks to destroy a window, we can hit this case with no
active browsing context. This seems odd, but perhaps is a spec issue as
well. Just log to dbgln for now.
This commit is contained in:
Andrew Kaster 2024-02-05 03:26:05 -07:00 committed by Andrew Kaster
parent d508a02f25
commit 813c66403d
Notes: sideshowbarker 2024-07-17 22:01:16 +09:00 
Author: https://github.com/ADKaster
Commit: https://github.com/SerenityOS/serenity/commit/813c66403d
Pull-request: https://github.com/SerenityOS/serenity/pull/23063
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/TraversableNavigable.cpp
View file

@ -888,7 +888,11 @@ void TraversableNavigable::destroy_top_level_traversable()
}
// 3. Remove browsingContext.
browsing_context->remove();
if (!browsing_context) {
dbgln("TraversableNavigable::destroy_top_level_traversable: No browsing context?");
} else {
browsing_context->remove();
}
// 4. Remove traversable from the user interface (e.g., close or hide its tab in a tabbed browser).
page().client().page_did_close_top_level_traversable();