beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Disallow async generator functions called 'await' or 'yield'

Browse source
This commit is contained in:
davidot 2021-12-19 20:19:15 +01:00 committed by Linus Groh
parent c8e80690a7
commit 81312986fe
Notes: sideshowbarker 2024-07-17 22:31:20 +09:00 
Author: https://github.com/davidot
Commit: https://github.com/SerenityOS/serenity/commit/81312986fe0
Pull-request: https://github.com/SerenityOS/serenity/pull/11316
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/linusg ✅
4 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibJS/Parser.cpp
View file

@ -2476,6 +2476,9 @@ NonnullRefPtr<FunctionNodeType> Parser::parse_function_node(u8 parse_options)
check_identifier_name_for_assignment_validity(name);
if (function_kind == FunctionKind::AsyncGenerator && (name == "await"sv || name == "yield"sv))
syntax_error(String::formatted("async generator function is not allowed to be called '{}'", name));
if (m_state.in_class_static_init_block && name == "await"sv)
syntax_error("'await' is a reserved word");
}

3
Userland/Libraries/LibJS/Tests/syntax/async-await.js
View file

@ -4,6 +4,9 @@ describe("parsing freestanding async functions", () => {
// Although it does not create an async function it is valid.
expect(`async
function foo() {}`).toEval();
expect(`async function await() {}`).toEval();
expect(`async function yield() {}`).toEval();
});
test("await expression", () => {
expect(`async function foo() { await bar(); }`).toEval();

3
Userland/Libraries/LibJS/Tests/syntax/async-generators.js
View file

@ -4,6 +4,9 @@ describe("parsing freestanding generators", () => {
expect(`async function *foo() {}`).toEval();
expect(`async function
*foo() {}`).toEval();
expect(`async function *await() {}`).not.toEval();
expect(`async function *yield() {}`).not.toEval();
});
test("yield & await expression", () => {
expect(`async function* foo() { yield; await 1; }`).toEval();

3
Userland/Libraries/LibJS/Tests/syntax/generators.js
View file

@ -4,6 +4,9 @@ describe("parsing freestanding generators", () => {
expect(`function *foo() {}`).toEval();
expect(`function
*foo() {}`).toEval();
expect(`function *await() {}`).toEval();
expect(`function *yield() {}`).toEval();
});
test("yield expression", () => {
expect(`function* foo() { yield; }`).toEval();