beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 00:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

CMake: Add back stricter warnings used in Serenity builds

Browse source 
These used to be enabled in `serenity_compile_options.cmake` for
Serenity builds and were removed in 9b05fb98. This is a slightly more
conservative subset of those, with ones that are enabled by default
omitted.

This should prevent our code quality regressing in the long run.
This commit is contained in:
Daniel Bertalan 2024-07-14 16:57:52 +02:00
parent 0961d68ebc
commit 7fe82a1cda
Notes: sideshowbarker 2024-07-18 08:27:17 +09:00 
Author: https://github.com/BertalanD
Commit: https://github.com/LadybirdBrowser/ladybird/commit/7fe82a1cda3
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/626
Reviewed-by: https://github.com/ADKaster ✅
Reviewed-by: https://github.com/trflynn89
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Meta/CMake/common_compile_options.cmake
View file

@ -19,8 +19,12 @@ else()
add_compile_options(-ffp-contract=off)
endif()
add_compile_options(-Wno-invalid-offsetof)
add_compile_options(-Wcast-qual)
add_compile_options(-Wformat=2)
add_compile_options(-Wimplicit-fallthrough)
add_compile_options(-Wsuggest-override)
add_compile_options(-Wno-invalid-offsetof)
add_compile_options(-Wno-unknown-warning-option)
add_compile_options(-Wno-unused-command-line-argument)

2
Userland/Libraries/LibGfx/ImageFormats/JPEGWriter.cpp
View file

@ -89,7 +89,7 @@ ErrorOr<void> JPEGWriter::encode_impl(Stream& stream, auto const& bitmap, Option
while (cinfo.next_scanline < cinfo.image_height) {
auto const* row_ptr = reinterpret_cast<u8 const*>(bitmap.scanline(cinfo.next_scanline));
JSAMPROW row_pointer = (JSAMPROW)row_ptr;
JSAMPROW row_pointer = const_cast<JSAMPROW>(row_ptr);
jpeg_write_scanlines(&cinfo, &row_pointer, 1);
}