beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

CMake: Don't recursively include Ladybird/Lagom in buggy CMake versions

Browse source 
Ran into this with the new EAP for CLion Nova. When using Ladybird as
source directory, we would recursively look in Ladybird --> Lagom -->
Ladybird when exporting components. This seems to be because
ENABLE_LAGOM_LADYBIRD is set to ON by Ladybird's CMakeLists and
something about their build, when invoked from their IDE, has buggy
behavior around the SUBDIRECTORIES directory property.
This commit is contained in:
Andrew Kaster 2023-11-09 20:52:57 -07:00 committed by Andreas Kling
parent 94b47ff03b
commit 7eda36bbf4
Notes: sideshowbarker 2024-07-17 09:41:18 +09:00 
Author: https://github.com/ADKaster
Commit: https://github.com/SerenityOS/serenity/commit/7eda36bbf4
Pull-request: https://github.com/SerenityOS/serenity/pull/21863
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Meta/Lagom/CMakeLists.txt
View file

@ -538,7 +538,10 @@ if (BUILD_LAGOM)
add_executable(gzip ../../Userland/Utilities/gzip.cpp)
target_link_libraries(gzip LibCompress LibCore LibMain)
if (ENABLE_LAGOM_LADYBIRD)
# FIXME: Use PROJECT_IS_TOPLEVEL with cmake 3.21
# Work around bug in JetBrains distributed CMake 3.27.2 where this causes infinite recursion in
# export_components() when called from CLion Nova by checking if we already have Ladybird included
if (ENABLE_LAGOM_LADYBIRD AND NOT ladybird_SOURCE_DIR)
add_serenity_subdirectory(Ladybird)
endif()