beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 01:20:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Remove FIXME if paintable is missing in getBoundingClientRect()

Browse source 
We should not print FIXME when paintable is missing (display: none)
because that means actually we can't to get a rect.
This commit is contained in:
Aliaksandr Kalenik 2023-12-16 15:53:29 +01:00 committed by Andreas Kling
parent 8f8ec37d58
commit 7d757fefeb
Notes: sideshowbarker 2024-07-16 23:08:48 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/7d757fefeb
Pull-request: https://github.com/SerenityOS/serenity/pull/22323
Reviewed-by: https://github.com/awesomekling
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -852,7 +852,10 @@ JS::NonnullGCPtr<Geometry::DOMRect> Element::get_bounding_client_rect() const
return Geometry::DOMRect::create(realm(), absolute_rect.to_type<float>());
}
dbgln("FIXME: Failed to get bounding client rect for element ({})", debug_description());
if (paintable) {
dbgln("FIXME: Failed to get bounding client rect for element ({})", debug_description());
}
return Geometry::DOMRect::construct_impl(realm(), 0, 0, 0, 0).release_value_but_fixme_should_propagate_errors();
}