beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibJS: Throw TypeError on non-object this value in ArrayBuffer methods

Browse source 
`1. If Type(O) is not Object, throw a TypeError exception.`
This commit is contained in:
Idan Horowitz 2021-06-10 22:42:10 +03:00 committed by Linus Groh
parent bc95201aaf
commit 7d6db3f09b
Notes: sideshowbarker 2024-07-18 12:28:18 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/7d6db3f09bb
Pull-request: https://github.com/SerenityOS/serenity/pull/7974
Reviewed-by: https://github.com/linusg
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibJS/Runtime/ArrayBufferPrototype.cpp
View file

@ -37,14 +37,11 @@ static ArrayBuffer* array_buffer_object_from(VM& vm, GlobalObject& global_object
{
// ArrayBuffer.prototype.* deliberately don't coerce |this| value to object.
auto this_value = vm.this_value(global_object);
if (!this_value.is_object())
return nullptr;
auto& this_object = this_value.as_object();
if (!is<ArrayBuffer>(this_object)) {
if (!this_value.is_object() || !is<ArrayBuffer>(this_value.as_object())) {
vm.throw_exception<TypeError>(global_object, ErrorType::NotAn, "ArrayBuffer");
return nullptr;
}
return static_cast<ArrayBuffer*>(&this_object);
return static_cast<ArrayBuffer*>(&this_value.as_object());
}
// 25.1.5.3 ArrayBuffer.prototype.slice, https://tc39.es/ecma262/#sec-arraybuffer.prototype.slice