beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Store the input image button's selected coordinates as integers

Browse source 
The spec has prose which states, e.g., "The x-component must be a valid
integer".
This commit is contained in:
Timothy Flynn 2024-02-19 07:44:11 -05:00 committed by Andreas Kling
parent 3f3db34587
commit 7bee1c9897
Notes: sideshowbarker 2024-07-17 07:43:44 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/7bee1c9897
Pull-request: https://github.com/SerenityOS/serenity/pull/23256
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -310,7 +310,11 @@ WebIDL::ExceptionOr<void> HTMLInputElement::run_input_activation_behavior(DOM::E
// coordinate to that coordinate.
if (event.is_trusted() && is<UIEvents::MouseEvent>(event)) {
auto const& mouse_event = static_cast<UIEvents::MouseEvent const&>(event);
m_selected_coordinate = { mouse_event.offset_x(), mouse_event.offset_y() };
CSSPixels x { mouse_event.offset_x() };
CSSPixels y { mouse_event.offset_y() };
m_selected_coordinate = { x.to_int(), y.to_int() };
}
// 4. Submit the element's form owner from the element with userInvolvement set to event's user navigation involvement.

4
Userland/Libraries/LibWeb/HTML/HTMLInputElement.h
View file

@ -105,8 +105,8 @@ public:
WebIDL::ExceptionOr<void> set_size(unsigned value);
struct SelectedCoordinate {
double x { 0.0 };
double y { 0.0 };
int x { 0 };
int y { 0 };
};
SelectedCoordinate selected_coordinate() const { return m_selected_coordinate; }