LibWeb: Implement AudioNode.numberOfInputs and .numberOfOutputs

Author: https://github.com/gmta
Commit: https://github.com/LadybirdBrowser/ladybird/commit/7b4f0d13eed
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1679

Userland/Libraries/LibWeb/WebAudio/AudioBufferSourceNode.h

@@ -41,6 +41,8 @@ public:
     double loop_start() const;
     WebIDL::ExceptionOr<void> set_loop_end(double);
     double loop_end() const;
+    WebIDL::UnsignedLong number_of_inputs() override { return 0; }
+    WebIDL::UnsignedLong number_of_outputs() override { return 2; }
 
     WebIDL::ExceptionOr<void> start(Optional<double>, Optional<double>, Optional<double>);
 

Userland/Libraries/LibWeb/WebAudio/AudioDestinationNode.h

@@ -23,6 +23,8 @@ public:
     virtual ~AudioDestinationNode() override;
 
     WebIDL::UnsignedLong max_channel_count();
+    WebIDL::UnsignedLong number_of_inputs() override { return 1; }
+    WebIDL::UnsignedLong number_of_outputs() override { return 1; }
 
     static JS::NonnullGCPtr<AudioDestinationNode> construct_impl(JS::Realm&, JS::NonnullGCPtr<BaseAudioContext>);
 

Userland/Libraries/LibWeb/WebAudio/AudioNode.cpp

@@ -98,20 +98,6 @@ void AudioNode::disconnect(JS::NonnullGCPtr<AudioParam> destination_param, WebID
     dbgln("FIXME: Implement AudioNode::disconnect(destination_param, output)");
 }
 
-// https://webaudio.github.io/web-audio-api/#dom-audionode-numberofinputs
-WebIDL::UnsignedLong AudioNode::number_of_inputs()
-{
-    dbgln("FIXME: Implement AudioNode::number_of_inputs()");
-    return 0;
-}
-
-// https://webaudio.github.io/web-audio-api/#dom-audionode-numberofoutputs
-WebIDL::UnsignedLong AudioNode::number_of_outputs()
-{
-    dbgln("FIXME: Implement AudioNode::number_of_outputs()");
-    return 0;
-}
-
 // https://webaudio.github.io/web-audio-api/#dom-audionode-channelcount
 WebIDL::ExceptionOr<void> AudioNode::set_channel_count(WebIDL::UnsignedLong channel_count)
 {

Userland/Libraries/LibWeb/WebAudio/AudioNode.h

@@ -48,8 +48,11 @@ public:
         return m_context;
     }
 
-    WebIDL::UnsignedLong number_of_inputs();
+    // https://webaudio.github.io/web-audio-api/#dom-audionode-numberofinputs
-    WebIDL::UnsignedLong number_of_outputs();
+    virtual WebIDL::UnsignedLong number_of_inputs() = 0;
+    // https://webaudio.github.io/web-audio-api/#dom-audionode-numberofoutputs
+    virtual WebIDL::UnsignedLong number_of_outputs() = 0;
+
     WebIDL::ExceptionOr<void> set_channel_count(WebIDL::UnsignedLong);
     WebIDL::UnsignedLong channel_count();
     WebIDL::ExceptionOr<void> set_channel_count_mode(Bindings::ChannelCountMode);

Userland/Libraries/LibWeb/WebAudio/BiquadFilterNode.h

@@ -29,6 +29,9 @@ class BiquadFilterNode : public AudioNode {
 public:
     virtual ~BiquadFilterNode() override;
 
+    WebIDL::UnsignedLong number_of_inputs() override { return 1; }
+    WebIDL::UnsignedLong number_of_outputs() override { return 1; }
+
     WebIDL::ExceptionOr<void> set_type(Bindings::BiquadFilterType);
     Bindings::BiquadFilterType type() const;
     JS::NonnullGCPtr<AudioParam> frequency() const;

Userland/Libraries/LibWeb/WebAudio/DynamicsCompressorNode.h

@@ -30,6 +30,9 @@ public:
     static WebIDL::ExceptionOr<JS::NonnullGCPtr<DynamicsCompressorNode>> create(JS::Realm&, JS::NonnullGCPtr<BaseAudioContext>, DynamicsCompressorOptions const& = {});
     static WebIDL::ExceptionOr<JS::NonnullGCPtr<DynamicsCompressorNode>> construct_impl(JS::Realm&, JS::NonnullGCPtr<BaseAudioContext>, DynamicsCompressorOptions const& = {});
 
+    WebIDL::UnsignedLong number_of_inputs() override { return 1; }
+    WebIDL::UnsignedLong number_of_outputs() override { return 1; }
+
     JS::NonnullGCPtr<AudioParam const> threshold() const { return m_threshold; }
     JS::NonnullGCPtr<AudioParam const> knee() const { return m_knee; }
     JS::NonnullGCPtr<AudioParam const> ratio() const { return m_ratio; }

Userland/Libraries/LibWeb/WebAudio/GainNode.h

@@ -27,6 +27,9 @@ public:
     static JS::NonnullGCPtr<GainNode> create(JS::Realm&, JS::NonnullGCPtr<BaseAudioContext>, GainOptions const& = {});
     static JS::NonnullGCPtr<GainNode> construct_impl(JS::Realm&, JS::NonnullGCPtr<BaseAudioContext>, GainOptions const& = {});
 
+    WebIDL::UnsignedLong number_of_inputs() override { return 1; }
+    WebIDL::UnsignedLong number_of_outputs() override { return 1; }
+
     JS::NonnullGCPtr<AudioParam const> gain() const { return m_gain; }
 
 protected:

Userland/Libraries/LibWeb/WebAudio/OscillatorNode.h

@@ -34,6 +34,8 @@ public:
     WebIDL::ExceptionOr<void> set_type(Bindings::OscillatorType);
 
     JS::NonnullGCPtr<AudioParam const> frequency() const { return m_frequency; }
+    WebIDL::UnsignedLong number_of_inputs() override { return 0; }
+    WebIDL::UnsignedLong number_of_outputs() override { return 1; }
 
 protected:
     OscillatorNode(JS::Realm&, JS::NonnullGCPtr<BaseAudioContext>, OscillatorOptions const& = {});