beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Utilities: Fix null deref in groupdel when given a nonexistent group

Browse source 
Found By PVS-Studio
This commit is contained in:
Brian Gianforcaro 2021-10-10 01:11:03 -07:00 committed by Brian Gianforcaro
parent fdfc0d1bac
commit 7b2506c054
Notes: sideshowbarker 2024-07-18 02:51:47 +09:00 
Author: https://github.com/bgianfo
Commit: https://github.com/SerenityOS/serenity/commit/7b2506c0546
Pull-request: https://github.com/SerenityOS/serenity/pull/10419
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/Utilities/groupdel.cpp
View file

@ -30,7 +30,6 @@ int main(int argc, char** argv)
}
char const* groupname = nullptr;
gid_t gid = 0;
Core::ArgsParser args_parser;
args_parser.add_positional_argument(groupname, "Group name", "group");
@ -38,14 +37,14 @@ int main(int argc, char** argv)
setgrent();
auto* g = getgrnam(groupname);
gid = g->gr_gid;
endgrent();
// Check if the group exists
if (!g) {
warnln("group {} does not exist", groupname);
return 6;
}
auto gid = g->gr_gid;
endgrent();
// Search if the group is the primary group of an user
setpwent();